linux-kernel - Re: [PATCH] block: Fix BLKRRPART regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbcf7378-e889-489a-92d2-1feb112cff58@nvidia.com>
Date: Tue, 16 Apr 2024 09:10:10 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: "hch@....de" <hch@....de>, Saranya Muruganandam <saranyamohan@...gle.com>
CC: "axboe@...nel.dk" <axboe@...nel.dk>, Shinichiro Kawasaki
	<shinichiro.kawasaki@....com>, "linux-block@...r.kernel.org"
	<linux-block@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>, "tj@...nel.org" <tj@...nel.org>,
	"yukuai1@...weicloud.com" <yukuai1@...weicloud.com>
Subject: Re: [PATCH] block: Fix BLKRRPART regression

On 4/12/2024 12:12 AM, Shinichiro Kawasaki wrote:
> On Apr 10, 2024 / 23:39, Saranya Muruganandam wrote:
>> The BLKRRPART ioctl used to report errors such as EIO before we changed
>> the blkdev_reread_part() logic.
>>
>> Add a flag and capture the errors returned by bdev_disk_changed()
>> when the flag is set. Set this flag for the BLKRRPART path when we
>> want the errors to be reported when rereading partitions on the disk.
>>
>> Link: https://lore.kernel.org/all/20240320015134.GA14267@lst.de/
>> Suggested-by: Christoph Hellwig <hch@....de>
>> Tested: Tested by simulating failure to the block device and will
>> propose a new test to blktests.
>> Fixes: 4601b4b130de ("block: reopen the device in blkdev_reread_part")
>> Reported-by: Saranya Muruganandam <saranyamohan@...gle.com>
>> Signed-off-by: Saranya Muruganandam <saranyamohan@...gle.com>
> 
> The change looks good to me. I also confirmed the fix with the new,
> corresponding blktests test case.
> 
> Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>
> Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>

which patch is the final one ? Is it this one or the one posted with
title :-

"block: propagate partition scanning errors to the BLKRRPART ioctl" ?

Please clarify so I can make sure to run some tests at my end.

-ck