[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANiq72msHmV7CXZVKehZLw4jtG9S_XsmX48OGNVp6sz32TMhtw@mail.gmail.com>
Date: Tue, 16 Apr 2024 11:34:38 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Trevor Gross <tmgross@...ch.edu>
Cc: dev@...yte.com, ojeda@...nel.org, alex.gaynor@...il.com,
wedsonaf@...il.com, boqun.feng@...il.com, gary@...yguo.net,
bjorn3_gh@...tonmail.com, benno.lossin@...ton.me, a.hindborg@...sung.com,
aliceryhl@...gle.com, rust-for-linux@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: update `dbg!()` to format column number
On Tue, Apr 16, 2024 at 7:58 AM Trevor Gross <tmgross@...ch.edu> wrote:
>
> The second link could be "Fixes: ..." (but whoever picks this up can
> probably do that)
`Fixes:` references a commit, not a URL. I think you meant `Closes:`,
but that one in turn is meant for bug fixes, which does not really fit
either. That is why I suggested `Link:` in the issue instead.
> Reviewed-by: Trevor Gross <tmgross@...ch.edu>
Thanks!
Cheers,
Miguel
Powered by blists - more mailing lists