linux-kernel - Re: [PATCH v3 6/9] media: subdev: Add v4l2_subdev_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2765261-e2ba-45f5-84af-4b55f8068318@ideasonboard.com>
Date: Tue, 16 Apr 2024 13:27:38 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
 Hans Verkuil <hverkuil@...all.nl>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Umang Jain <umang.jain@...asonboard.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 6/9] media: subdev: Add v4l2_subdev_is_streaming()

On 12/04/2024 21:15, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Wed, Apr 10, 2024 at 03:35:53PM +0300, Tomi Valkeinen wrote:
>> Add a helper function which returns whether the subdevice is streaming,
>> i.e. if .s_stream or .enable_streams has been called successfully.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
>> ---
>>   drivers/media/v4l2-core/v4l2-subdev.c | 25 +++++++++++++++++++++++++
>>   include/media/v4l2-subdev.h           | 13 +++++++++++++
>>   2 files changed, 38 insertions(+)
>>
>> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
>> index 3d2c9c224b8f..20b5a00cbeeb 100644
>> --- a/drivers/media/v4l2-core/v4l2-subdev.c
>> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
>> @@ -2419,6 +2419,31 @@ void v4l2_subdev_notify_event(struct v4l2_subdev *sd,
>>   }
>>   EXPORT_SYMBOL_GPL(v4l2_subdev_notify_event);
>>   
>> +bool v4l2_subdev_is_streaming(struct v4l2_subdev *sd)
>> +{
>> +	struct v4l2_subdev_state *state;
>> +
>> +	if (!v4l2_subdev_has_op(sd, pad, enable_streams))
>> +		return sd->streaming_enabled;
>> +
>> +	state = v4l2_subdev_get_locked_active_state(sd);
>> +
>> +	if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS))
>> +		return !!sd->enabled_pads;
> 
> I think this can be moved above the
> v4l2_subdev_get_locked_active_state() call.

Yep. I think I originally thought that it'll be nice to get a warning 
here if the state is not locked, but perhaps that's pointless.

> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> Any plan to convert drivers to this ?

No. Afaics, it will be per-driver manual work, no way to automate it.

  Tomi