linux-kernel - Re: [PATCH] net: ipa: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Apr 2024 11:50:35 +0100
From: Simon Horman <horms@...nel.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: elder@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] net: ipa: Remove unnecessary print function dev_err()

On Mon, Apr 15, 2024 at 11:14:56AM +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
> 
> ./drivers/net/ipa/ipa_interrupt.c:300:2-9: line 300 is redundant because platform_get_irq() already prints an error.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8756
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Hi Jiapeng Chong,

I don't think that you need to repost because of this,
but when sending Networking patches please specify the target tree
in the subject; net for fixes, and net-next for other patches.

e.g.

	Subject: [PATCH net-next] ...

That notwithstanding, this patch looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>