linux-kernel - Re: [PATCH] coccinelle: misc: minmax: Suppress reports for err returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiDSCuvXvjfhw2mjSef1wR8RiL=9KrDEoh+3o1ed4+8P+AqGw@mail.gmail.com>
Date: Tue, 16 Apr 2024 13:32:52 +0200
From: Ricardo Ribalda <ribalda@...omium.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Julia Lawall <Julia.Lawall@...ia.fr>, cocci@...ia.fr, 
	LKML <linux-kernel@...r.kernel.org>, Denis Efremov <efremov@...ux.com>, 
	Nicolas Palix <nicolas.palix@...g.fr>
Subject: Re: [PATCH] coccinelle: misc: minmax: Suppress reports for err returns

Hi Markus

On Tue, 16 Apr 2024 at 13:30, Markus Elfring <Markus.Elfring@....de> wrote:
>
> …
> > +++ b/scripts/coccinelle/misc/minmax.cocci
> > @@ -50,11 +50,26 @@ func(...)
> >       ...>
> >  }
> >
> > +// Ignore errcode returns.
> > +@...code@
> …
>
> I see that you would like to omit the specification “depends on patch”
> from the previous SmPL rule location.
>
> Would you really like to influence and adjust SmPL code any more
> according to affected coccicheck operation modes?

I probably do not know what I am doing :), it is my first .cocci patch.

If I leave the "depends on patch", then the change is ignored in report mode.

I think errcode needs to be executed in report and in patch mode, but
there might be a better way to do it.

>
> Regards,
> Markus



-- 
Ricardo Ribalda