linux-kernel - [PATCH 1/3] media: tuners: tda18271: fix error code handling in tda18271

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240416114509.198069-1-r.smirnov@omp.ru>
Date: Tue, 16 Apr 2024 14:45:07 +0300
From: Roman Smirnov <r.smirnov@....ru>
To: Michael Krufky <mkrufky@...uxtv.org>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Jia-Ju Bai <baijiaju1990@...il.com>, Hans Verkuil
	<hverkuil-cisco@...all.nl>
CC: Roman Smirnov <r.smirnov@....ru>, <linux-media@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Sergey Shtylyov <s.shtylyov@....ru>,
	<lvc-project@...uxtesting.org>
Subject: [PATCH 1/3] media: tuners: tda18271: fix error code handling in tda18271_attach()

tda18271_attach() uses the hybrid_tuner_request_state() macro.
It may return the error code -ENOMEM, but the function handle
the value 0 instead.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Fixes: b9302fa7ed97 ("media: tuners: fix error return code of hybrid_tuner_request_state()")
Signed-off-by: Roman Smirnov <r.smirnov@....ru>
---
 drivers/media/tuners/tda18271-fe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/tuners/tda18271-fe.c b/drivers/media/tuners/tda18271-fe.c
index a7e721baaa99..23432210f06a 100644
--- a/drivers/media/tuners/tda18271-fe.c
+++ b/drivers/media/tuners/tda18271-fe.c
@@ -1255,7 +1255,7 @@ struct dvb_frontend *tda18271_attach(struct dvb_frontend *fe, u8 addr,
 					      hybrid_tuner_instance_list,
 					      i2c, addr, "tda18271");
 	switch (instance) {
-	case 0:
+	case -ENOMEM:
 		goto fail;
 	case 1:
 		/* new tuner instance */
-- 
2.34.1