linux-kernel - Re: [PATCH v1 0/2] s390/mm: fix improper use of __storage_key_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Apr 2024 15:24:31 +0200
From: Heiko Carstens <hca@...ux.ibm.com>
To: Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>
Cc: linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        frankja@...ux.ibm.com, nrb@...ux.ibm.com, nsg@...ux.ibm.com,
        borntraeger@...ibm.com, gerald.schaefer@...ux.ibm.com,
        david@...hat.com
Subject: Re: [PATCH v1 0/2] s390/mm: fix improper use of
 __storage_key_init_range

On Tue, Apr 16, 2024 at 01:42:18PM +0200, Claudio Imbrenda wrote:
> The function __storage_key_init_range() expects the end address to be
> the first byte outside the range to be initialized. I.e. end - start
> should be the size of the area to be initialized.
> 
> This small series fixes two cases in which the last address in the
> range was passed as end address. This was still functionally correct,
> since __storage_key_init_range() will still loop over single pages and
> correctly clear the given range, but it will be slower than clearing
> the storage keys for the whole 1M block with a single instruction.
> 
> Claudio Imbrenda (2):
>   s390/mm: fix storage key clearing for guest huge pages
>   s390/mm: fix clearing storage keys for huge pages
> 
>  arch/s390/mm/gmap.c        | 2 +-
>  arch/s390/mm/hugetlbpage.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Heiko Carstens <hca@...ux.ibm.com>