linux-kernel - Re: [EXTERNAL] Re: [PATCH v2 1/3] ALSA: hda/tas2781: Modification for add tas2781 driver for SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zh6E5PzTfxawXVbT@smile.fi.intel.com>
Date: Tue, 16 Apr 2024 17:02:12 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Xu, Baojun" <baojun.xu@...com>
Cc: "tiwai@...e.de" <tiwai@...e.de>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"perex@...ex.cz" <perex@...ex.cz>,
	"pierre-louis.bossart@...ux.intel.com" <pierre-louis.bossart@...ux.intel.com>,
	"Lu, Kevin" <kevin-lu@...com>,
	"Ding, Shenghao" <shenghao-ding@...com>,
	"Navada Kanyana, Mukund" <navada@...com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
	"yung-chuan.liao@...ux.intel.com" <yung-chuan.liao@...ux.intel.com>,
	"broonie@...nel.org" <broonie@...nel.org>,
	"soyer@....hu" <soyer@....hu>,
	"13916275206@....com" <13916275206@....com>
Subject: Re: [EXTERNAL] Re: [PATCH v2 1/3] ALSA: hda/tas2781: Modification
 for add tas2781 driver for SPI

On Tue, Apr 16, 2024 at 07:45:21AM +0000, Xu, Baojun wrote:
> > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Sent: 09 April 2024 21:02
> > On Tue, Apr 09, 2024 at 10: 48: 13AM +0800, Baojun Xu wrote:
> > On Tue, Apr 09, 2024 at 10:48:13AM +0800, Baojun Xu wrote:

..

> > > @@ -39,6 +39,7 @@ snd-hda-scodec-cs35l56-spi-objs :=  cs35l56_hda_spi.o
> > >  snd-hda-cs-dsp-ctls-objs :=          hda_cs_dsp_ctl.o
> > >  snd-hda-scodec-component-objs :=     hda_component.o
> > >  snd-hda-scodec-tas2781-i2c-objs :=   tas2781_hda_i2c.o
> > > +snd-hda-scodec-tas2781-spi-objs :=   tas2781_hda_spi.o tas2781_spi_fwlib.o
> > 
> > Actually these 'objs' has to be 'y', can you fix it in the prerequisite patch?
> 
> Do you mean set CONFIG_SND_HDA_SCODEC_TAS2781_SPI=y in .config?

No. I mean the Kconfig syntax in use. -objs is for user space tools. Kernel
code should use -y in this case.

> It's m now.
> 
> > Also wondering why fwlib is only a requirement for SPI. How does I²C work?
> 
> Because in I2C mode, one probed device driver will support all devices,
> firmware binary is only one file, include all of devices.
> But in SPI mode, multi driver probed, so we use single firmware binary for
> every spi device.

But does I²C version still need the firmware? Can't the FW handling be factored
out to a single module for both?

-- 
With Best Regards,
Andy Shevchenko