linux-kernel - Re: [PATCH RFC net-next 7/7] netdev_features: convert NETIF_F_FCOE_MTU to IFF_FCOE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 16 Apr 2024 07:19:40 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, David Ahern
 <dsahern@...nel.org>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Andrew Lunn
 <andrew@...n.ch>, <nex.sw.ncis.osdt.itp.upstreaming@...el.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC net-next 7/7] netdev_features: convert
 NETIF_F_FCOE_MTU to IFF_FCOE_MTU

On Tue, 16 Apr 2024 14:45:42 +0200 Alexander Lobakin wrote:
> >> This whole enum could be made as bitfields, should we convert it? Would
> >> be a big patch tho ._.  
> > 
> > As always, I haven't investigated closely :) But my thinking was -
> > we are at 34 bits in priv. We just need to convert 2 of them to
> > a bitfield, pick two with fewest uses. Then we can downgrade 
> > the field to u32 from ulonglong, and we can carry on adding bitfields?  
> 
> Hmm, sounds good. You mean convert the existing bits which don't fit
> into u32 to bitfields and then add new priv flags as bitfields?

Yes