linux-kernel - Re: [PATCH] perf vendor events arm64: AmpereOne/AmpereOneX: Mark L1D_CACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zh_wEU6bdshoD2aO@x1>
Date: Wed, 17 Apr 2024 12:51:45 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: James Clark <james.clark@....com>
Cc: Ilkka Koskinen <ilkka@...amperecomputing.com>,
	Will Deacon <will@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	John Garry <john.g.garry@...cle.com>,
	Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...ux.dev>,
	Namhyung Kim <namhyung@...nel.org>, Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH] perf vendor events arm64: AmpereOne/AmpereOneX: Mark
 L1D_CACHE_INVAL impacted by errata

On Tue, Apr 09, 2024 at 02:33:18PM +0100, James Clark wrote:
> On 08/04/2024 22:40, Ilkka Koskinen wrote:
> > L1D_CACHE_INVAL overcounts in certain situations. See AC03_CPU_41 and
> > AC04_CPU_1 for more details. Mark the event impacted by the errata.
> > 
> > Signed-off-by: Ilkka Koskinen <ilkka@...amperecomputing.com>
> > ---
> >  tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json  | 4 +++-
> >  tools/perf/pmu-events/arch/arm64/ampere/ampereonex/cache.json | 4 +++-
> >  2 files changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json
> > index 7a2b7b200f14..ac75f12e27bf 100644
> > --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json
> > +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json
> > @@ -9,7 +9,9 @@
> >          "ArchStdEvent": "L1D_CACHE_REFILL_RD"
> >      },
> >      {
> > -        "ArchStdEvent": "L1D_CACHE_INVAL"
> > +        "ArchStdEvent": "L1D_CACHE_INVAL",
> > +        "Errata": "Errata AC03_CPU_41",
> > +        "BriefDescription": "L1D cache invalidate. Impacted by errata -"
> >      },
> >      {
> >          "ArchStdEvent": "L1D_TLB_REFILL_RD"
> > diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/cache.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/cache.json
> > index c50d8e930b05..f4bfe7083a6b 100644
> > --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/cache.json
> > +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/cache.json
> > @@ -9,7 +9,9 @@
> >          "ArchStdEvent": "L1D_CACHE_REFILL_RD"
> >      },
> >      {
> > -        "ArchStdEvent": "L1D_CACHE_INVAL"
> > +        "ArchStdEvent": "L1D_CACHE_INVAL",
> > +        "Errata": "Errata AC04_CPU_1",
> > +        "BriefDescription": "L1D cache invalidate. Impacted by errata -"
> >      },
> >      {
> >          "ArchStdEvent": "L1D_TLB_REFILL_RD"
 
> Reviewed-by: James Clark <james.clark@....com>

Thanks, applied to perf-tools-next,

- Arnaldo