linux-kernel - Re: [PATCH v2 3/8] ASoC: dt-bindings: wcd937x-sdw: add bindings for wcd937x-sdw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 17 Apr 2024 17:52:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mohammad Rafi Shaik <quic_mohs@...cinc.com>, Rob Herring <robh@...nel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Banajit Goswami <bgoswami@...cinc.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
 linux-arm-msm@...r.kernel.org, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 quic_rohkumar@...cinc.com, quic_pkumpatl@...cinc.com
Subject: Re: [PATCH v2 3/8] ASoC: dt-bindings: wcd937x-sdw: add bindings for
 wcd937x-sdw

On 17/04/2024 10:17, Mohammad Rafi Shaik wrote:
> On 4/16/2024 8:02 PM, Rob Herring wrote:
>> On Tue, Apr 16, 2024 at 12:05:55PM +0530, Mohammad Rafi Shaik wrote:
>>> From: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
>>>
>>> Qualcomm WCD9370/WCD9375 Codec is a standalone Hi-Fi audio codec IC
>>> connected over SoundWire. This device has two SoundWire devices RX and
>>> TX respectively.
>>> This binding is for those slave devices on WCD9370/WCD9375.
>>>
>>> Co-developed-by: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
>>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
>>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
>>> ---
>>>   .../bindings/sound/qcom,wcd937x-sdw.yaml      | 71 +++++++++++++++++++
>>>   1 file changed, 71 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml
>>> new file mode 100644
>>> index 000000000000..2b7358e266ba
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml
>>> @@ -0,0 +1,71 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/sound/qcom,wcd937x-sdw.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Qualcomm SoundWire Slave devices on WCD9370
>>> +
>>> +maintainers:
>>> +  - Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>>> +
>>> +description: |
>>
>> Don't need '|' if no formatting.
>>
>>> +  Qualcomm WCD9370 Codec is a standalone Hi-Fi audio codec IC.
>>> +  It has RX and TX Soundwire slave devices. This bindings is for the
>>> +  slave devices.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: sdw20217010a00
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  qcom,tx-port-mapping:
>>> +    description: |
>>> +      Specifies static port mapping between slave and master tx ports.
>>> +      In the order of slave port index.
>>
>> Are there constraints on the values of the entries?
> 
> The port mapping entries are fixed values.
> There is no constraints.

If they are fixed, then for sure you have constraints, because they are
known. I really do not understand your response.

Best regards,
Krzysztof