[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VctFbys8ARoE9ZqsCSCOYWjsZnR80g+YXstbyzo5r6TYw@mail.gmail.com>
Date: Wed, 17 Apr 2024 20:06:00 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Alisa-Dariana Roman <alisadariana@...il.com>
Cc: michael.hennerich@...log.com, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
alexandru.tachici@...log.com, lars@...afoo.de, jic23@...nel.org,
robh@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
lgirdwood@...il.com, broonie@...nel.org, andy@...nel.org, nuno.sa@...log.com,
marcelo.schmitt@...log.com, bigunclemax@...il.com, dlechner@...libre.com,
okan.sahin@...log.com, fr0st61te@...il.com, alisa.roman@...log.com,
marcus.folkesson@...il.com, schnelle@...ux.ibm.com, liambeguin@...il.com
Subject: Re: [PATCH v6 5/5] iio: adc: ad7192: Add AD7194 support
On Wed, Apr 17, 2024 at 8:01 PM Alisa-Dariana Roman
<alisadariana@...il.com> wrote:
>
> Unlike the other AD719Xs, AD7194 has configurable differential
> channels. The user can dynamically configure them in the devicetree.
>
> Also modify config AD7192 description for better scaling.
..
> + device_for_each_child_node(dev, child) {
You can use scoped variant AFAIU that's available in Jonathan's tree.
> + *ad7194_channels = ad7194_chan_diff;
> + ad7194_channels->scan_index = index++;
> + ret = ad7194_parse_channel(child, ad7194_channels);
> + if (ret) {
> + fwnode_handle_put(child);
With the above this wouldn't be needed.
> + return ret;
> + }
> + ad7194_channels++;
> + }
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists