linux-kernel - Re: [PATCH] mm/page_table_check: Support userfault wr-protect entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZiAbK63JshbyW48z@x1n>
Date: Wed, 17 Apr 2024 14:55:39 -0400
From: Peter Xu <peterx@...hat.com>
To: Pasha Tatashin <pasha.tatashin@...een.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	David Hildenbrand <david@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nadav Amit <nadav.amit@...il.com>,
	Axel Rasmussen <axelrasmussen@...gle.com>
Subject: Re: [PATCH] mm/page_table_check: Support userfault wr-protect entries

On Wed, Apr 17, 2024 at 02:51:48PM -0400, Pasha Tatashin wrote:
> This breaks linux-next build:
> 
> mm/page_table_check.c: In function ‘swap_cached_writable’:
> mm/page_table_check.c:192:24: error: ‘SWP_DEVICE_EXCLUSIVE_WRITE’
> undeclared (first use in this function)
>   192 |         return type == SWP_DEVICE_EXCLUSIVE_WRITE ||
>       |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
> mm/page_table_check.c:192:24: note: each undeclared identifier is
> reported only once for each function it appears in
> mm/page_table_check.c:194:1: error: control reaches end of non-void
> function [-Werror=return-type]
>   194 | }
> 
> Looks like there is a dependence on CONFIG_DEVICE_PRIVATE.

Right, same to SWP_MIGRATION_WRITE.

I've already sent a v2 with everything fixed, please have a look.  I also
added one more device private entry type that I overlooked.

Thanks,

-- 
Peter Xu