linux-kernel - Re: [PATCH v2 2/8] ASoC: codecs: wcd937x: add wcd937x codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5e9e2a4-5506-4cce-b218-ec9a5baff40a@linaro.org>
Date: Wed, 17 Apr 2024 22:40:57 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
Cc: alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Jaroslav Kysela <perex@...ex.cz>, Banajit Goswami <bgoswami@...cinc.com>,
 quic_rohkumar@...cinc.com, Takashi Iwai <tiwai@...e.com>,
 devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
 Trilok Soni <quic_tsoni@...cinc.com>,
 Bjorn Andersson <quic_bjorande@...cinc.com>,
 Alex Elder <alex.elder@...aro.org>
Subject: Re: [PATCH v2 2/8] ASoC: codecs: wcd937x: add wcd937x codec driver



On 16.04.2024 8:35 AM, Prasad Kumpatla wrote:
> This patch adds basic SoundWire codec driver to support for
> WCD937X TX and RX devices.
> 
> WCD937x has Multi Button Headset Control hardware to support Headset
> insertion, type detection, 8 headset buttons detection, Over Current
> detection and Impedence measurements.
> This patch adds support for this using wcd-mbhc apis.
> ---
>  sound/soc/codecs/wcd937x.c | 1583 ++++++++++++++++++++++++++++++++++++
>  sound/soc/codecs/wcd937x.h |  617 ++++++++++++++
>  2 files changed, 2200 insertions(+)
>  create mode 100644 sound/soc/codecs/wcd937x.c
>  create mode 100644 sound/soc/codecs/wcd937x.h
> 
> diff --git a/sound/soc/codecs/wcd937x.c b/sound/soc/codecs/wcd937x.c
> new file mode 100644
> index 000000000000..d29cb56630c7
> --- /dev/null
> +++ b/sound/soc/codecs/wcd937x.c
> @@ -0,0 +1,1583 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +// Copyright (c) 2023-2024 Qualcomm Innovation Center, Inc. All rights reserved.

Well this is pretty disappointing

This is clearly built upon my commit [1] (which itself is built upon QC
downstream, for which it retains the QuIC copyright), which can be seen
e.g. in the funny bitwise ORing in wcd937x_set_micbias_data or the
precise comments/function ordering..

Please at least include the Linaro copyright.

Konrad

[1] https://git.codelinaro.org/konrad.dybcio/linux/-/commit/a62f9c6fc53d4249e9de57898821e5ca4d2e7ca2