[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJpo=nd8ywUzz2e42p7WAyuFm439yvNf6H=MD63LCV0xTnw@mail.gmail.com>
Date: Wed, 17 Apr 2024 08:57:26 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Herman van Hazendonk <github.com@...rie.org>
Cc: andersson@...nel.org, benwolsieffer@...il.com, chris.chapuis@...il.com,
conor+dt@...nel.org, devicetree@...r.kernel.org, kishon@...nel.org,
konrad.dybcio@...aro.org, krzk+dt@...nel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org, me@...rie.org,
robh@...nel.org, vkoul@...nel.org
Subject: Re: [PATCH v2] dt-bindings: phy: qcom,usb-hs-phy: Add compatible
On Wed, 17 Apr 2024 at 07:52, Herman van Hazendonk
<github.com@...rie.org> wrote:
>
> Adds qcom,usb-hs-phy-msm8660 compatible
>
> Used by HP Touchpad (tenderloin) for example.
>
> Signed-off-by: Herman van Hazendonk <github.com@...rie.org>
> ---
> Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> index f042d6af1594..ccf23170cd17 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> @@ -15,6 +15,7 @@ if:
> contains:
> enum:
> - qcom,usb-hs-phy-apq8064
> + - qcom,usb-hs-phy-msm8660
> - qcom,usb-hs-phy-msm8960
> then:
> properties:
> @@ -41,6 +42,7 @@ properties:
> - enum:
> - qcom,usb-hs-phy-apq8064
> - qcom,usb-hs-phy-msm8226
> + - qcom,usb-hs-phy-msm8960
This should probably be msm8660 rather than 8960
Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy
compatible, but I wonder if we should enforce this for such an old
platform or whether similarity wins.
> - qcom,usb-hs-phy-msm8916
> - qcom,usb-hs-phy-msm8960
> - qcom,usb-hs-phy-msm8974
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists