linux-kernel - Re: [PATCH net-next v8 04/17] ethtool: Expand Ethernet Power Equipment with c33 (PoE) alongside PoDL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240417081249.1e92dab2@kmaincent-XPS-13-7390>
Date: Wed, 17 Apr 2024 08:12:49 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
 <corbet@....net>, Luis Chamberlain <mcgrof@...nel.org>, Russ Weight
 <russ.weight@...ux.dev>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, Oleksij Rempel <o.rempel@...gutronix.de>, Mark Brown
 <broonie@...nel.org>, Frank Rowand <frowand.list@...il.com>, Andrew Lunn
 <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, devicetree@...r.kernel.org, Dent Project
 <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime Chevallier
 <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v8 04/17] ethtool: Expand Ethernet Power
 Equipment with c33 (PoE) alongside PoDL

On Tue, 16 Apr 2024 19:20:37 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> On Sun, 14 Apr 2024 16:21:53 +0200 Kory Maincent wrote:
> > + * @ETHTOOL_C33_PSE_PW_D_STATUS_DISABLED: "The enumeration
> > \u201cdisabled\u201d
> > + *	indicates that the PSE State diagram is in the state DISABLED."
> > + * @ETHTOOL_C33_PSE_PW_D_STATUS_SEARCHING: "The enumeration
> > \u201csearching\u201d
> > + *	indicates the PSE State diagram is in a state other than those
> > + *	listed."
> > + * @ETHTOOL_C33_PSE_PW_D_STATUS_DELIVERING: "The enumeration
> > + *	\u201cdeliveringPower\u201d indicates that the PSE State diagram
> > is in the
> > + *	state POWER_ON."
> > + * @ETHTOOL_C33_PSE_PW_D_STATUS_TEST: "The enumeration \u201ctest\u201d
> > indicates that
> > + *	the PSE State diagram is in the state TEST_MODE."
> > + * @ETHTOOL_C33_PSE_PW_D_STATUS_FAULT: "The enumeration \u201cfault\u201d
> > indicates that
> > + *	the PSE State diagram is in the state TEST_ERROR."
> > + * @ETHTOOL_C33_PSE_PW_D_STATUS_OTHERFAULT: "The enumeration
> > \u201cotherFault\u201d  
> 
> funny characters here: \u201c and \u201d

Arf again, I have learned the hard way of do not copy past some documentation
from the standard to Linux.
Thanks Jakub, for the reviewing and the merge try!

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com