linux-kernel - Re: [PATCH] checkpatch: error if file terminates without a new-line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 17 Apr 2024 06:36:10 +0000 (UTC)
From: Prasad Pandit <pjp@...oraproject.org>
To: Joe Perches <joe@...ches.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	Dwaipayan Ray <dwaipayanray1@...il.com>, 
	Lukas Bulwahn <lukas.bulwahn@...il.com>, 
	Andy Whitcroft <apw@...onical.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH] checkpatch: error if file terminates without a new-line

On Tuesday, 16 April, 2024 at 03:25:18 pm IST, Joe Perches wrote: 
>There's an existing check for this. Fix that instead.
>
># check for adding lines without a newline.
>        if ($line =~ /^\+/ && defined $lines[$linenr]
>            && $lines[$linenr] =~ /^\\ No newline >at end of file/) {
>            if (WARN("MISSING_EOF_NEWLINE",
>                    "adding a line without newline at end of file\n" . $herecurr) &&
>                $fix) {
>                fix_delete_line($fixlinenr+1, "No newline at end of file");


Okay, will check; Thank you.
---
  -Prasad