linux-kernel - [PATCH] scsi: qla2xxx: edif: Fix an error code problem in qla24xx_sadb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Wed, 17 Apr 2024 16:27:01 +0800
From: Su Hui <suhui@...china.com>
To: njavali@...vell.com,
	GR-QLogic-Storage-Upstream@...vell.com,
	jejb@...ux.ibm.com,
	martin.petersen@...cle.com,
	nathan@...nel.org,
	ndesaulniers@...gle.com,
	morbo@...gle.com,
	justinstitt@...gle.com
Cc: Su Hui <suhui@...china.com>,
	rhicksted@...vell.com,
	hare@...e.de,
	himanshu.madhani@...cle.com,
	qutran@...vell.com,
	linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev,
	kernel-janitors@...r.kernel.org
Subject: [PATCH] scsi: qla2xxx: edif: Fix an error code problem in qla24xx_sadb_update()

Clang Static Checker (scan-build) Warning:
drivers/scsi/qla2xxx/qla_edif.c:line 1568, column 3
Value stored to 'rval' is never read.

Return the error code rather than zero to dismiss this warning.

Fixes: dd30706e73b7 ("scsi: qla2xxx: edif: Add key update")
Signed-off-by: Su Hui <suhui@...china.com>
---
 drivers/scsi/qla2xxx/qla_edif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
index dcde55c8ee5d..6f1aac36a144 100644
--- a/drivers/scsi/qla2xxx/qla_edif.c
+++ b/drivers/scsi/qla2xxx/qla_edif.c
@@ -1836,7 +1836,7 @@ qla24xx_sadb_update(struct bsg_job *bsg_job)
 	bsg_job_done(bsg_job, bsg_reply->result,
 	    bsg_reply->reply_payload_rcv_len);
 
-	return 0;
+	return rval;
 }
 
 static void
-- 
2.30.2