linux-kernel - Re: [PATCH v1 5/6] regulator: mtk-dvfsrc-regulator: Refactor and add MT8192/MT8195 vregs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8cd2b23-f5e0-4692-a149-3ec98adb94b8@collabora.com>
Date: Wed, 17 Apr 2024 10:30:55 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Mark Brown <broonie@...nel.org>
Cc: djakov@...nel.org, robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org, matthias.bgg@...il.com, lgirdwood@...il.com,
 keescook@...omium.org, gustavoars@...nel.org, henryc.chen@...iatek.com,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, kernel@...labora.com,
 wenst@...omium.org, amergnat@...libre.com
Subject: Re: [PATCH v1 5/6] regulator: mtk-dvfsrc-regulator: Refactor and add
 MT8192/MT8195 vregs

Il 17/04/24 02:52, Mark Brown ha scritto:
> On Tue, Apr 16, 2024 at 05:38:04PM +0200, AngeloGioacchino Del Regno wrote:
>> This driver never worked, and never got even compiled, because it was
>> missing the DVFSRC driver entirely, including headers it relies on!
>>
>> Perform a full (or nearly full) refactoring of the MediaTek DVFSRC
>> controlled Regulators driver: this retains support for the MT6873,
>> MT8183 and MT8192 SoCs, and adds MT8195.
>>
>> As part of the refactoring, this driver is now probed using its own
>> devicetree compatible, as this is a child of the main DVFSRC driver
>> and gets probed as a subnode of that.
> 
> Given what you're doing this would probably be easier to review as
> two commits, one removing the existing driver and another adding the new
> code.

Yeah, definitely.... I'll do that for v2.

Cheers,
Angelo