linux-kernel - Re: [PATCH v5 1/5] virt: vmgenid: rearrange code to make review easier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5351cd46-7228-48d8-b1a2-8ab91dce24f7@amazon.de>
Date: Wed, 17 Apr 2024 11:12:45 +0200
From: Alexander Graf <graf@...zon.de>
To: Babis Chalios <bchalios@...zon.es>, <tytso@....edu>, <Jason@...c4.com>,
	<olivia@...enic.com>, <herbert@...dor.apana.org.au>, <robh@...nel.org>,
	<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <linux-crypto@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <sudanl@...zon.com>, <xmarcalx@...zon.co.uk>, <dwmw@...zon.co.uk>
Subject: Re: [PATCH v5 1/5] virt: vmgenid: rearrange code to make review
 easier


On 17.04.24 11:05, Babis Chalios wrote:
>
>
> On 17/4/24 10:35, Alexander Graf wrote:
>>
>> On 17.04.24 10:12, Babis Chalios wrote:
>>> From: Sudan Landge <sudanl@...zon.com>
>>>
>>> Rearrage the functions of vmgenid to make the next commit,
>>> which re-implements vmgenid as a platform driver, easier to review.
>>>
>>> Signed-off-by: Sudan Landge <sudanl@...zon.com>
>>
>>
>> You can't sign off on behalf of someone else. The SoB here needs to 
>> be yours. If you are taking over this code from Sudan, I'd suggest to 
>> take over full ownership of it and put your own name as author and 
>> SoB in all patches.
>>
>
> I thought about it and it seemed weird to me that I take over SoB and 
> authorship since I only touched one line in one of
> the patches, but I will be taking over the patches, so I can do that 
> if that's the way we things are done.
>
> Does it make sense to at least add "Co-authored-by Sudan Landge 
> <sudanl@...zon.com>" here?


You can certainly do that, yes.


Alex





Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879