linux-kernel - Re: [PATCH v4 3/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-boost-crypt property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12cc437d2213720190a2fcf132411cfe4485f5d0.camel@mediatek.com>
Date: Wed, 17 Apr 2024 09:29:33 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"wenst@...omium.org" <wenst@...omium.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "avri.altman@....com" <avri.altman@....com>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
	"bvanassche@....org" <bvanassche@....org>, "broonie@...nel.org"
	<broonie@...nel.org>, "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "lgirdwood@...il.com" <lgirdwood@...il.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "amergnat@...libre.com" <amergnat@...libre.com>
Subject: Re: [PATCH v4 3/8] scsi: ufs: ufs-mediatek: Remove useless
 mediatek,ufs-boost-crypt property

On Wed, 2024-04-17 at 10:14 +0200, AngeloGioacchino Del Regno wrote:
> 
> 
> Upstream supports platforms that do and don't need this feature, and
> having
> redundant device tree properties performing the same checks is not
> just
> suboptimal but plain wrong.
> 
> Adding to this, devicetree describes the hardware - and there is no
> physical
> hardware switch that needs this redundant property, this means that
> the
> property that is getting removed in this commit (and the va09 one in
> another
> commit of this series) is a *software switch*, not HW.
> 
> Keep in mind, also, that this feature (and again, the va09 one as
> well) has
> a specific requirement to be supported - and this is what the code
> does even
> without the software switch to add it.
> 
> In case there's any need to disallow such feature from a specific
> SoC, the DT
> bindings can be modified such that a specific compatible string would
> disallow
> adding the required regulator and/or boost-microvolt properties.
> 
> Besides, I want to remind you that there is no reason to drop
> support, or have
> them unreliably working, or use hacks, for SoCs that are "old" -
> especially
> when this is a driver that works on both old and new ones.
> 
> Regards,
> Angelo

Hi Angelo,

These two property(boost and va09) is not software switch, they
are hardware switch. Because if platform support crypto boost, we set
boost property in device tree. And if platform support ufs va09, we set
va09 proberty in device tree. These property are main hardware switch.

We don't use sub switch like voltage or clock setting becasue it is
not intiutive. Especially when va09 is not used by ufs (No va09
property but have va09 voltage), The behavior should be wrong if ufs
control va09 which used by other module.

Thanks.
Peter