linux-kernel - Re: [PATCH v2 3/7] irqchip/gic-v3-its: Avoid explicit cpumask allocation on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86v84gqmuw.wl-maz@kernel.org>
Date: Wed, 17 Apr 2024 11:56:07 +0100
From: Marc Zyngier <maz@...nel.org>
To: Dawei Li <dawei.li@...ngroup.cn>
Cc: tglx@...utronix.de,
	yury.norov@...il.com,
	rafael@...nel.org,
	akpm@...ux-foundation.org,
	florian.fainelli@...adcom.com,
	chenhuacai@...nel.org,
	jiaxun.yang@...goat.com,
	anup@...infault.org,
	palmer@...belt.com,
	samuel.holland@...ive.com,
	linux@...musvillemoes.dk,
	daniel.lezcano@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] irqchip/gic-v3-its: Avoid explicit cpumask allocation on stack

On Tue, 16 Apr 2024 09:54:50 +0100,
Dawei Li <dawei.li@...ngroup.cn> wrote:
> 
> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
> 
> Remove cpumask var on stack and use cpumask_any_and() to address it.
> 
> Signed-off-by: Dawei Li <dawei.li@...ngroup.cn>

Reviewed-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.