linux-kernel - drivers/net/phy/motorcomm.c:885:12-14: WARNING opportunity for min() (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2119db14-c2a-9bd3-eae8-4faa5219dbc3@inria.fr>
Date: Wed, 17 Apr 2024 14:34:27 +0200 (CEST)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Samin Guo <samin.guo@...rfivetech.com>, 
    Hal Feng <hal.feng@...rfivetech.com>, Andrew Lunn <andrew@...n.ch>
cc: linux-kernel@...r.kernel.org, oe-kbuild-all@...ts.linux.dev
Subject: drivers/net/phy/motorcomm.c:885:12-14: WARNING opportunity for min()
 (fwd)



---------- Forwarded message ----------
Date: Wed, 17 Apr 2024 20:21:23 +0800
From: kernel test robot <lkp@...el.com>
To: oe-kbuild@...ts.linux.dev
Cc: lkp@...el.com, Julia Lawall <julia.lawall@...ia.fr>
Subject: drivers/net/phy/motorcomm.c:885:12-14: WARNING opportunity for min()

BCC: lkp@...el.com
CC: oe-kbuild-all@...ts.linux.dev
CC: linux-kernel@...r.kernel.org
TO: Samin Guo <samin.guo@...rfivetech.com>
CC: Hal Feng <hal.feng@...rfivetech.com>
CC: Andrew Lunn <andrew@...n.ch>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   96fca68c4fbf77a8185eb10f7557e23352732ea2
commit: 7a561e9351ae7e3fb1f08584d40b49c1e55dde60 net: phy: motorcomm: Add pad drive strength cfg support
date:   9 months ago
:::::: branch date: 2 days ago
:::::: commit date: 9 months ago
config: i386-randconfig-053-20240417 (https://download.01.org/0day-ci/archive/20240417/202404172059.wU4sM9Qi-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Julia Lawall <julia.lawall@...ia.fr>
| Closes: https://lore.kernel.org/r/202404172059.wU4sM9Qi-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/net/phy/motorcomm.c:885:12-14: WARNING opportunity for min()

vim +885 drivers/net/phy/motorcomm.c

7a561e9351ae7e3 Samin Guo 2023-07-20  877
7a561e9351ae7e3 Samin Guo 2023-07-20  878  static u32 yt8531_get_ldo_vol(struct phy_device *phydev)
7a561e9351ae7e3 Samin Guo 2023-07-20  879  {
7a561e9351ae7e3 Samin Guo 2023-07-20  880  	u32 val;
7a561e9351ae7e3 Samin Guo 2023-07-20  881
7a561e9351ae7e3 Samin Guo 2023-07-20  882  	val = ytphy_read_ext_with_lock(phydev, YT8521_CHIP_CONFIG_REG);
7a561e9351ae7e3 Samin Guo 2023-07-20  883  	val = FIELD_GET(YT8531_RGMII_LDO_VOL_MASK, val);
7a561e9351ae7e3 Samin Guo 2023-07-20  884
7a561e9351ae7e3 Samin Guo 2023-07-20 @885  	return val <= YT8531_LDO_VOL_1V8 ? val : YT8531_LDO_VOL_1V8;
7a561e9351ae7e3 Samin Guo 2023-07-20  886  }
7a561e9351ae7e3 Samin Guo 2023-07-20  887

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki