linux-kernel - Re: [PATCH 22/35] media: i2c: st-mipid02: Use the correct div function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea60a9e8-6240-4a0a-a224-e132b67160b1@foss.st.com>
Date: Wed, 17 Apr 2024 14:55:45 +0200
From: Benjamin Mugnier <benjamin.mugnier@...s.st.com>
To: Ricardo Ribalda <ribalda@...omium.org>,
        Martin Tuma
	<martin.tuma@...iteqautomotive.com>,
        Mauro Carvalho Chehab
	<mchehab@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Hugues Fruchet
	<hugues.fruchet@...s.st.com>,
        Alain Volmat <alain.volmat@...s.st.com>,
        Maxime
 Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue
	<alexandre.torgue@...s.st.com>,
        Paul Kocialkowski
	<paul.kocialkowski@...tlin.com>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec
	<jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Sakari
 Ailus <sakari.ailus@...ux.intel.com>,
        Thierry Reding
	<thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Sowjanya
 Komatineni <skomatineni@...dia.com>,
        Luca Ceresoli
	<luca.ceresoli@...tlin.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
        Hans
 Verkuil <hverkuil@...all.nl>, Sergey Kozlov <serjk@...up.ru>,
        Abylay Ospan
	<aospan@...up.ru>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
        Dmitry
 Osipenko <digetx@...il.com>,
        Stanimir Varbanov
	<stanimir.k.varbanov@...il.com>,
        Vikash Garodia <quic_vgarodia@...cinc.com>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Sylvain
 Petinot <sylvain.petinot@...s.st.com>,
        Jacopo Mondi
	<jacopo+renesas@...ndi.org>,
        Kieran Bingham
	<kieran.bingham+renesas@...asonboard.com>,
        Laurent Pinchart
	<laurent.pinchart+renesas@...asonboard.com>,
        Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
        Pavel Machek <pavel@....cz>
CC: <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-staging@...ts.linux.dev>, <linux-sunxi@...ts.linux.dev>,
        <linux-tegra@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH 22/35] media: i2c: st-mipid02: Use the correct div
 function

Hi Ricardo,

Thanks a lot.
Reviewed-by: Benjamin Mugnier <benjamin.mugnier@...s.st.com>

On 4/15/24 21:34, Ricardo Ribalda wrote:
> link_freq does not fit in 32 bits.
> 
> Found by cocci:
> drivers/media/i2c/st-mipid02.c:329:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_s64 instead.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> ---
>  drivers/media/i2c/st-mipid02.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c
> index f250640729ca..93a40bfda1af 100644
> --- a/drivers/media/i2c/st-mipid02.c
> +++ b/drivers/media/i2c/st-mipid02.c
> @@ -326,7 +326,7 @@ static int mipid02_configure_from_rx_speed(struct mipid02_dev *bridge,
>  	}
>  
>  	dev_dbg(&client->dev, "detect link_freq = %lld Hz", link_freq);
> -	do_div(ui_4, link_freq);
> +	ui_4 = div64_s64(ui_4, link_freq);
>  	bridge->r.clk_lane_reg1 |= ui_4 << 2;
>  
>  	return 0;
> 

-- 
Regards,

Benjamin