linux-kernel - Re: [PATCH 1/2] dt-bindings: net/nfc: ti,trf7970a: Add rx-gain-reduction option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 17 Apr 2024 15:12:05 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Paul Geurts <paul_geurts@...e.nl>, mgreer@...malcreek.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, robh@...nel.org, conor+dt@...nel.org,
 linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: net/nfc: ti,trf7970a: Add
 rx-gain-reduction option

On 17/04/2024 00:18, Paul Geurts wrote:
> Add option to reduce the RX antenna gain to be able to reduce the
> sensitivity.
> 
> Signed-off-by: Paul Geurts <paul_geurts@...e.nl>
> ---
>  Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> index d0332eb76ad2..bbd045f6cf04 100644
> --- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> +++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> @@ -55,6 +55,11 @@ properties:
>      description: |
>        Regulator for supply voltage to VIN pin
>  
> +  rx-gain-reduction:

Missing vendor prefix.

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      Specify a RX gain reduction to reduce antenna sensitivity.

Reduction by what? What are the units?


Best regards,
Krzysztof