linux-kernel - Re: [PATCH v5 1/5] virt: vmgenid: rearrange code to make review easier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 17 Apr 2024 15:19:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Jason A. Donenfeld" <Jason@...c4.com>, Babis Chalios <bchalios@...zon.es>
Cc: Alexander Graf <graf@...zon.de>, tytso@....edu, olivia@...enic.com,
 herbert@...dor.apana.org.au, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, linux-crypto@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, sudanl@...zon.com,
 xmarcalx@...zon.co.uk, dwmw@...zon.co.uk
Subject: Re: [PATCH v5 1/5] virt: vmgenid: rearrange code to make review
 easier

On 17/04/2024 14:42, Jason A. Donenfeld wrote:
> On Wed, Apr 17, 2024 at 11:05:27AM +0200, Babis Chalios wrote:
>>
>>
>> On 17/4/24 10:35, Alexander Graf wrote:
>>>
>>> On 17.04.24 10:12, Babis Chalios wrote:
>>>> From: Sudan Landge <sudanl@...zon.com>
>>>>
>>>> Rearrage the functions of vmgenid to make the next commit,
>>>> which re-implements vmgenid as a platform driver, easier to review.
>>>>
>>>> Signed-off-by: Sudan Landge <sudanl@...zon.com>
>>>
>>>
>>> You can't sign off on behalf of someone else. The SoB here needs to be 
>>> yours. If you are taking over this code from Sudan, I'd suggest to 
>>> take over full ownership of it and put your own name as author and SoB 
>>> in all patches.
>>>
>>
>> I thought about it and it seemed weird to me that I take over SoB and 
>> authorship since I only touched one line in one of
>> the patches, but I will be taking over the patches, so I can do that if 
>> that's the way we things are done.
>>
>> Does it make sense to at least add "Co-authored-by Sudan Landge 
>> <sudanl@...zon.com>" here?
> 
> Wait, what? No. If you didn't write these patches, you're not the
> author. Sudan is the author. However, if they passed through you, it's
> fine to add your S-o-b. You can even mention the trivial change you made
> between Sudan's S-o-b and your own.
> 

It is not "fine" but it is a must. Regardless if you changed something
or not, you *must* provide your SoB since you generated the patch.
Babis, please read carefully submitting patches. Especially the DCO
part, but entire document is important.

Best regards,
Krzysztof