lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240417-spectral-doberman-of-prosperity-d2c0cc@lemur>
Date: Wed, 17 Apr 2024 09:55:52 -0400
From: Konstantin Ryabitsev <konstantin@...uxfoundation.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Thorsten Leemhuis <linux@...mhuis.info>, helpdesk@...nel.org, 
	"workflows@...r.kernel.org" <workflows@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: Please create the email alias do-not-apply-to-stable@...nel.org
 -> /dev/null

On Wed, Apr 17, 2024 at 03:38:28PM +0200, Greg KH wrote:
> > That afaics makes them useless for the stable team (Greg may correct 
> > me
> > if I'm wrong here), as they deal with the commits and have no easy,
> > fast, and reliable way to look up the patch posting to query this. Or is
> > the "patch basement" available somehow in git for each commit and I just
> > missed that?
> 
> You are correct, as-is, that would make it useless for my tools.
> 
> BUT I could, if it's possible, just look up the original in lore somehow
> and parse that.  If it's there, does anyone have a "simple" way to map a
> git commit back to a lore message if it does NOT have a Link: line in
> it?

Our current way of doing it is going by patch-id, and it's not great 
either, because there is more than one way to create a patch from a git 
commit. We've discovered this when Linus recommended that people send 
patches with the --histogram algorithm, which broke a bunch of our 
stuff. :)

E.g. here's a recent commit that has a Fixes:

  git show c0297e7dd50795d559f3534887a6de1756b35d0f | git patch-id --stable | cut -d' ' -f1
  c2f5c42a5a3bc05ffacd9679dd367e4a2207b018

it successfully maps to the patch:
https://lore.kernel.org/all/?q=patchid%3Ac2f5c42a5a3bc05ffacd9679dd367e4a2207b018

I only put this here for academic purposes -- I really don't want you to 
go that route, because it's fragile (more fragile than git notes, and 
that's saying something).

-K

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ