linux-kernel - Re: [PATCH] hrtimer: Remove unused function hrtimer_hres

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wmow3vr4.fsf@somnus>
Date: Wed, 17 Apr 2024 16:32:31 +0200
From: Anna-Maria Behnsen <anna-maria@...utronix.de>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: frederic@...nel.org, tglx@...utronix.de, linux-kernel@...r.kernel.org,
 Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, Abaci Robot
 <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] hrtimer: Remove unused function hrtimer_hres_active

Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> writes:

> The function are defined in the hrtimer.c file, but not called
> elsewhere, so delete the unused function.
>
> kernel/time/hrtimer.c:653:19: warning: unused function 'hrtimer_hres_active'.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8778
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  kernel/time/hrtimer.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
> index cae9d04b5584..bdaf23356d4b 100644
> --- a/kernel/time/hrtimer.c
> +++ b/kernel/time/hrtimer.c
> @@ -650,11 +650,6 @@ static inline int __hrtimer_hres_active(struct hrtimer_cpu_base *cpu_base)
>  		cpu_base->hres_active : 0;
>  }
>  
> -static inline int hrtimer_hres_active(void)
> -{
> -	return __hrtimer_hres_active(this_cpu_ptr(&hrtimer_bases));
> -}
> -
>  static void __hrtimer_reprogram(struct hrtimer_cpu_base *cpu_base,
>  				struct hrtimer *next_timer,
>  				ktime_t expires_next)


Can you please rename __hrtimer_hres_active() to hrtimer_hres_active()
and remove the old hrtimer_hres_active() function?

Btw. you could add a

  Fixes: 82ccdf062a64 ("hrtimer: Remove unused function")

as the warning was introduced by removing the last (unused) callsite
__hrtimer_peek_ahead_timers().

Thanks,

	Anna-Maria