linux-kernel - Re: [PATCH] spi: dt-bindings: armada-3700: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240417-clobber-brought-49867bc036bd@spud>
Date: Wed, 17 Apr 2024 16:13:49 +0100
From: Conor Dooley <conor@...nel.org>
To: Kousik Sanagavarapu <five231003@...il.com>
Cc: Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Shuah Khan <skhan@...uxfoundation.org>,
	Javier Carrasco <javier.carrasco.cruz@...il.com>,
	linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: dt-bindings: armada-3700: convert to dtschema

On Wed, Apr 17, 2024 at 10:57:06AM +0530, Kousik Sanagavarapu wrote:
> Convert txt binding of marvell armada 3700 SoC spi controller to dtschema
> to allow for validation.
> 
> Signed-off-by: Kousik Sanagavarapu <five231003@...il.com>
> ---
>  .../bindings/spi/marvell,armada-3700-spi.yaml | 55 +++++++++++++++++++
>  .../bindings/spi/spi-armada-3700.txt          | 25 ---------
>  2 files changed, 55 insertions(+), 25 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml
>  delete mode 100644 Documentation/devicetree/bindings/spi/spi-armada-3700.txt
> 
> diff --git a/Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml b/Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml
> new file mode 100644
> index 000000000000..61caa1d86188
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/marvell,armada-3700-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Armada 3700 SPI Controller
> +
> +description:
> +  The SPI controller on Marvell Armada 3700 SoC.
> +
> +maintainers:
> +  - Kousik Sanagavarapu <five231003@...il.com>
> +
> +allOf:
> +  - $ref: spi-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: marvell,armada-3700-spi
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  num-cs:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    spi0: spi@...00 {

Iff there's a resubmission, drop the lavel here since it has no users.

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.

> +        compatible = "marvell,armada-3700-spi";
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        reg = <0x10600 0x5d>;
> +        clocks = <&nb_perih_clk 7>;
> +        interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> +        num-cs = <4>;
> +    };
> +...
> diff --git a/Documentation/devicetree/bindings/spi/spi-armada-3700.txt b/Documentation/devicetree/bindings/spi/spi-armada-3700.txt
> deleted file mode 100644
> index 1564aa8c02cd..000000000000
> --- a/Documentation/devicetree/bindings/spi/spi-armada-3700.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -* Marvell Armada 3700 SPI Controller
> -
> -Required Properties:
> -
> -- compatible: should be "marvell,armada-3700-spi"
> -- reg: physical base address of the controller and length of memory mapped
> -       region.
> -- interrupts: The interrupt number. The interrupt specifier format depends on
> -	      the interrupt controller and of its driver.
> -- clocks: Must contain the clock source, usually from the North Bridge clocks.
> -- num-cs: The number of chip selects that is supported by this SPI Controller
> -- #address-cells: should be 1.
> -- #size-cells: should be 0.
> -
> -Example:
> -
> -	spi0: spi@...00 {
> -		compatible = "marvell,armada-3700-spi";
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -		reg = <0x10600 0x5d>;
> -		clocks = <&nb_perih_clk 7>;
> -		interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> -		num-cs = <4>;
> -	};
> -- 
> 2.44.0.548.g91ec36f2cc
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)