linux-kernel - Re: [PATCH v2] wifi: ath11k: Fix error handling in ath11k_wmi_p2p_noa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <171345363078.934743.11630888726665265520.kvalo@kernel.org>
Date: Thu, 18 Apr 2024 15:20:32 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Jeff Johnson <jjohnson@...nel.org>, Kang Yang <quic_kangyang@...cinc.com>,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Jeff Johnson <quic_jjohnson@...cinc.com>,
 Kalle Valo <quic_kvalo@...cinc.com>, linux-wireless@...r.kernel.org,
 ath11k@...ts.infradead.org
Subject: Re: [PATCH v2] wifi: ath11k: Fix error handling in
 ath11k_wmi_p2p_noa_event()

Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> if (noa_descriptors > WMI_P2P_MAX_NOA_DESCRIPTORS), there is a mix of
> return and goto. In such a case, 'td' should be freed to avoid a memory
> leak.
> 
> While at it, change ath11k_wmi_p2p_noa_event() to return void.
> '0' was returned in all cases, even in case of error and the only caller
> does not handle the return value.
> This is also more consistent with most of functions called from
> ath11k_wmi_tlv_op_rx().
> 
> Fixes: 2408379f15a1 ("wifi: ath11k: implement handling of P2P NoA event")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Acked-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Patch applied to ath-next branch of ath.git, thanks.

6ef5b4c9598c wifi: ath11k: Fix error handling in ath11k_wmi_p2p_noa_event()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/07f1fc75b2d5b4173ae1b7bb1da5be7f6fc608c8.1713212781.git.christophe.jaillet@wanadoo.fr/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches