linux-kernel - Re: [PATCH] wifi: ath12k: don't use %pK in dmesg format strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <171345386046.934743.6076422265444894161.kvalo@kernel.org>
Date: Thu, 18 Apr 2024 15:24:21 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Jeff Johnson <jjohnson@...nel.org>, <linux-wireless@...r.kernel.org>,
 <ath12k@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
 Jeff Johnson <quic_jjohnson@...cinc.com>
Subject: Re: [PATCH] wifi: ath12k: don't use %pK in dmesg format strings

Jeff Johnson <quic_jjohnson@...cinc.com> wrote:

> Currently, when debug logs are enabled, messages such as the following
> are found in the kernel log:
> 
> event mgmt rx skb         pK-error len 209 ftype 00 stype 50
> 
> The "pK-error" comes from using %pK to display an skb address in an
> interrupt context.
> 
> Per the guidance in the current "printk-formats" documentation, %pK
> "is only intended when producing content of a file read by userspace
> from e.g. procfs or sysfs, not for dmesg."
> 
> So replace %pK with %p in all of the ath12k_dbg() format strings.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Patch applied to ath-next branch of ath.git, thanks.

2372c6d28032 wifi: ath12k: don't use %pK in dmesg format strings

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240416-pk-v1-1-2c8852743e6d@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches