linux-kernel - Re: [PATCH v2 12/18] dt-bindings: pwm: mediatek,pwm-disp: add compatible for mt8365 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jl35q23p7axlxaxxwo7652qke5luft4x6zsz3ldntegdpvmdom@ge6taosuwtnj>
Date: Thu, 18 Apr 2024 18:05:41 +0200
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Alexandre Mergnat <amergnat@...libre.com>
Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, David Airlie <airlied@...il.com>, 
	Daniel Vetter <daniel@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
	Conor Dooley <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Jitao Shi <jitao.shi@...iatek.com>, CK Hu <ck.hu@...iatek.com>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, dri-devel@...ts.freedesktop.org, 
	linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-pwm@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v2 12/18] dt-bindings: pwm: mediatek,pwm-disp: add
 compatible for mt8365 SoC

Hello Alexandre,

On Thu, Apr 18, 2024 at 11:46:11AM +0200, Alexandre Mergnat wrote:
> On 17/04/2024 10:06, Uwe Kleine-König wrote:
> > On Tue, Apr 16, 2024 at 05:53:13PM +0200, Alexandre Mergnat wrote:
> > > Add a compatible string for MediaTek Genio 350 MT8365's display PWM
> > > block: this is the same as MT8183.
> > > 
> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > > Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > > Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>
> > 
> > I already asked in reply to v1 what the merge plan is here. There are
> > changes in my pwm tree to the mediatek,pwm-disp binding already. I don't
> > think they conflict with this patch, but maybe it's still easier to take
> > this via pwm?!
> 
> Sorry, I though the merge strategy wasn't addressed to me because I'm not a maintainer.

Well, you're the canonical person who has an interest to get this series
in, so you can at least have and express an idea. In my experience it's
good to be proactive and suggest a merge plan. Maintainers are triggered
more to reply by a presented plan they don't agree with than with
suggesting a plan themselves. And this way at least there is less
surprise for you as submitter.

> It's fine for me to merge it in the PWM tree.
> IMO, this change [1] shouldn't conflict with this patch.

FTR: [1] is in Linus's tree already now.

> Can you add the "Acked-by: Rob Herring (Arm) <robh@...nel.org>" please if you merge this version ?

I picked the one from your v3 series now where you included Rob's Ack. I
was a bit grumpy because I only spotted your reply here afterwards.
(Everything fine now on my side now.)

Best regards
Uwe

> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git/commit/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml?h=pwm/for-next&id=fb7c3d8ba039df877886fd457538d8b24ca9c84b

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)