linux-kernel - Re: [PATCH] ASoC: dt-bindings: fsl,ssi: Convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47dea00a-79b5-452c-958d-eb56d4577119@kernel.org>
Date: Thu, 18 Apr 2024 19:14:45 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shengjiu Wang <shengjiu.wang@...il.com>
Cc: Shengjiu Wang <shengjiu.wang@....com>, lgirdwood@...il.com,
 broonie@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: fsl,ssi: Convert to YAML

On 18/04/2024 05:04, Shengjiu Wang wrote:

>>> +  "#sound-dai-cells":
>>> +    const: 0
>>> +    description: optional, some dts node didn't add it.
>>
>> The question is: is this DAI or not?
> 
> Yes, it is a DAI. so, is there any issue here?
> 
>>
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - interrupts
>>> +  - fsl,fifo-depth
>>> +
>>> +unevaluatedProperties: false
>>
>> This must be additionalProperties:false. Use example-schema as
>> reference... unless you want to reference dai-common.yaml, but then that
>> one is missing.
> 
> As it is a DAI,  so I should include dai-common.yaml,  right?

Yes and then unevaluated is correct.

Best regards,
Krzysztof