linux-kernel - Re: [PATCH v3 0/3] add support for EXAR XR20M1172 UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZiFes8AQgcj_SZ5V@smile.fi.intel.com>
Date: Thu, 18 Apr 2024 20:56:03 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Konstantin Pugin <rilian.la.te@...ru>
Cc: Konstantin Pugin <ria.freelander@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>,
	Hugo Villeneuve <hvilleneuve@...onoff.com>,
	Lech Perczak <lech.perczak@...lingroup.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH v3 0/3] add support for EXAR XR20M1172 UART

On Thu, Apr 18, 2024 at 08:06:04PM +0300, Konstantin Pugin wrote:
> From: Konstantin Pugin <ria.freelander@...il.com>
> 
> EXAR XR20M1172 UART is mostly SC16IS762-compatible, but
> it has additional register which can change UART multiplier
> to 4x and 8x, similar to UPF_MAGIC_MULTIPLIER does. So, I used this
> flag to guard access to its specific DLD register. It seems than
> other EXAR SPI UART modules also have this register, but I tested
> only XR20M1172.

> Yes, in datasheet this register is called "DLD - Divisor Fractional"
> or "DLD - Divisor Fractional Register", calling depends on datasheet
> version.

I see, interesting inconsistency, but that's what we have to live with.

..

I just have noticed that you haven't used the updated base for your series,
you need to take Greg's KH tty tree and use tty-next / tty-testing branch(es).

Speaking of base, start using --base when preparing patches, it helps CIs to
test against correct branches.

-- 
With Best Regards,
Andy Shevchenko