linux-kernel - Re: [PATCH v4 1/3] LoongArch: Modify acpi_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 18 Apr 2024 11:15:05 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc: Thomas Gleixner <tglx@...utronix.de>, Arnd Bergmann <arnd@...db.de>, Marc Zyngier <maz@...nel.org>, 
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH v4 1/3] LoongArch: Modify acpi_parse_processor() for non-SMP

Hi, Tiezhu,

On Wed, Apr 17, 2024 at 6:00 PM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>
> When CONFIG_SMP is disabled, mapping won't be created for all cpus.
> CPUs more than num_possible_cpus will be ignored. This is preparation
> for later patch.
This patch makes no sense, don't "fix" anything unless it is broken.

Huacai

>
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>  arch/loongarch/kernel/acpi.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kernel/acpi.c b/arch/loongarch/kernel/acpi.c
> index 5cf59c617126..ccfa90faf0ea 100644
> --- a/arch/loongarch/kernel/acpi.c
> +++ b/arch/loongarch/kernel/acpi.c
> @@ -98,8 +98,15 @@ acpi_parse_processor(union acpi_subtable_headers *header, const unsigned long en
>                 return -EINVAL;
>
>         acpi_table_print_madt_entry(&header->common);
> +
> +       /*
> +        * When CONFIG_SMP is disabled, mapping won't be created for all cpus.
> +        * CPUs more than num_possible_cpus will be ignored.
> +        */
> +       if (processor->core_id >= 0 && processor->core_id < num_possible_cpus())
> +               acpi_core_pic[processor->core_id] = *processor;
> +
>  #ifdef CONFIG_SMP
> -       acpi_core_pic[processor->core_id] = *processor;
>         set_processor_mask(processor->core_id, processor->flags);
>  #endif
>
> --
> 2.42.0
>
>