linux-kernel - Re: [PATCH v1] i2c: i2c-qcom-geni: Add support to share an I2C SE from two subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a18b752-c13a-4b46-ae71-59b8372dd953@quicinc.com>
Date: Fri, 19 Apr 2024 00:31:51 +0530
From: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <andersson@...nel.org>,
        <vkoul@...nel.org>, <andi.shyti@...nel.org>, <wsa@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <dmaengine@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-i2c@...r.kernel.org>
CC: <quic_vdadhani@...cinc.com>
Subject: Re: [PATCH v1] i2c: i2c-qcom-geni: Add support to share an I2C SE
 from two subsystem

Hi Konrad, Thanks for confirming your preferences.

On 4/16/2024 5:14 AM, Konrad Dybcio wrote:
> 
> 
> On 4/2/24 08:21, Mukesh Kumar Savaliya wrote:
>> Thanks Konrad for detailed review. For dt-bindings sending a separate 
>> patch soon, rest comments tried to address and updated patch V2.
> 
> [...]
> 
>>>> +    if (of_property_read_bool(pdev->dev.of_node, "qcom,shared-se")) {
>>>> +        gi2c->is_shared = true;
>>>> +        dev_info(&pdev->dev, "Multi-EE usecase with shared SE\n");
>>>
>>> How would this line be useful in my kernel log?
>>>
>> It informs that particular SE is shared between SEs from two 
>> subsystems, hence respective debug can happen accordingly in case of 
>> the issue.
> 
> This amounts to "not very useful". As an end user, I couldn't care less
> about the nitty-gritty of firmware-hardware interactions, so long as the
> thing works. You must not spam the kernel log with debug messages, as it
> slows things down and makes actually useful messages harder to spot. If
> you want to keep it, use dev_dbg.
> 
Sure, will go with the dev_dbg. I am uploading a separate patches for 
i2c and GSI DMA sub system.
> Konrad