linux-kernel - Re: [PATCH 2/2] mm/hugetlb: fix unable to handle page fault for address dead000000000108

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240418133817.afb65c8dcd11cfea7c686d25@linux-foundation.org>
Date: Thu, 18 Apr 2024 13:38:17 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Miaohe Lin <linmiaohe@...wei.com>
Cc: <muchun.song@...ux.dev>, <david@...hat.com>, <vbabka@...e.cz>,
 <willy@...radead.org>, <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mm/hugetlb: fix unable to handle page fault for
 address dead000000000108

On Thu, 18 Apr 2024 10:20:00 +0800 Miaohe Lin <linmiaohe@...wei.com> wrote:

> Below panic occurs when I did memory failure test:
> 
> BUG: unable to handle page fault for address: dead000000000108
> 
> ...
>
> The root cause is that list_del() is used to remove folio from list when
> dissolve_free_hugetlb_folio(). But list_move() might be used to reenqueue
> hugetlb folio when free_huge_folio() leading to above panic. Fix this
> issue by using list_del_init() to remove folio.
> 
> ...
>
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1642,7 +1642,7 @@ static void __remove_hugetlb_folio(struct hstate *h, struct folio *folio,
>  	if (hstate_is_gigantic(h) && !gigantic_page_runtime_supported())
>  		return;
>  
> -	list_del(&folio->lru);
> +	list_del_init(&folio->lru);
>  
>  	if (folio_test_hugetlb_freed(folio)) {
>  		h->free_huge_pages--;

We should cc:stable and find a Fixes:.  This appears to predate
6eb4e88a6d27022ea8aff424d47a0a5dfc9fcb34, after which I got lost.