linux-kernel - Re: [PATCH RESEND] fpga: dfl: omit unneeded casts of u64 values for dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 18 Apr 2024 21:30:48 +0000
From: "Colberg, Peter" <peter.colberg@...el.com>
To: "yilun.xu@...ux.intel.com" <yilun.xu@...ux.intel.com>
CC: "Xu, Yilun" <yilun.xu@...el.com>, "linux-fpga@...r.kernel.org"
	<linux-fpga@...r.kernel.org>, "mdf@...nel.org" <mdf@...nel.org>,
	"andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>, "Wu,
 Hao" <hao.wu@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "russ.weight@...ux.dev"
	<russ.weight@...ux.dev>, "Pagani, Marco" <marpagan@...hat.com>, "Rix, Tom"
	<trix@...hat.com>, "matthew.gerlach@...ux.intel.com"
	<matthew.gerlach@...ux.intel.com>
Subject: Re: [PATCH RESEND] fpga: dfl: omit unneeded casts of u64 values for
 dev_dbg()

On Tue, 2024-04-02 at 11:29 +0800, Xu Yilun wrote:
> On Thu, Mar 28, 2024 at 08:04:29PM -0400, Peter Colberg wrote:
> > Omit unneeded casts of u64 values to unsigned long long for use with
> > printk() format specifier %llx. Unlike user space, the kernel defines
> > u64 as unsigned long long for all architectures; see commit 2a7930bd77fe
> > ("Documentation/printk-formats.txt: No casts needed for u64/s64").
> 
> The change is OK. But I suggest just delete the unnecessary dev_dbg()
> since now people normally don't want these "Hello, I'm here!" info.

How would you like me to proceed? Should I remove dev_dbg() in all DFL
modules? There are "Hello, I'm here!" in non-DFL FPGA modules, too.

$ rg --sort=path -c dev_dbg drivers/fpga/
drivers/fpga/altera-freeze-bridge.c:7
drivers/fpga/altera-pr-ip-core.c:1
drivers/fpga/dfl-afu-dma-region.c:7
drivers/fpga/dfl-afu-error.c:1
drivers/fpga/dfl-afu-main.c:8
drivers/fpga/dfl-fme-error.c:1
drivers/fpga/dfl-fme-main.c:3
drivers/fpga/dfl-fme-mgr.c:12
drivers/fpga/dfl-fme-perf.c:2
drivers/fpga/dfl-fme-pr.c:1
drivers/fpga/dfl-fme-region.c:1
drivers/fpga/dfl-n3000-nios.c:1
drivers/fpga/dfl-pci.c:3
drivers/fpga/dfl.c:4
drivers/fpga/fpga-bridge.c:4
drivers/fpga/fpga-region.c:3
drivers/fpga/socfpga-a10.c:2
drivers/fpga/stratix10-soc.c:4

Thanks,
Peter