linux-kernel - Re: [PATCH 1/2] completion: move blk_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZiCoIHFLAzCva2lU@infradead.org>
Date: Wed, 17 Apr 2024 21:57:04 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Mikulas Patocka <mpatocka@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>,
	Mike Snitzer <msnitzer@...hat.com>, Jens Axboe <axboe@...nel.dk>,
	Damien Le Moal <dlemoal@...nel.org>, Ingo Molnar <mingo@...hat.com>,
	Will Deacon <will@...nel.org>, Waiman Long <longman@...hat.com>,
	Guangwu Zhang <guazhang@...hat.com>, dm-devel@...ts.linux.dev,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] completion: move blk_wait_io to
 kernel/sched/completion.c

On Wed, Apr 17, 2024 at 08:00:22PM +0200, Mikulas Patocka wrote:
> > > +EXPORT_SYMBOL(wait_for_completion_long_io);
> > 
> > Urgh, why is it a sane thing to circumvent the hang check timer? 
> 
> The block layer already does it - the bios can have arbitrary size, so 
> waiting for them takes arbitrary time.

And as mentioned the last few times around, I think we want a task
state to say that task can sleep long or even forever and not propagate
this hack even further.