linux-kernel - Re: [PATCH 2/2] media: i2c: Add driver for ST VD56G3 camera sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202404181322.l6Ajlqbf-lkp@intel.com>
Date: Thu, 18 Apr 2024 13:39:36 +0800
From: kernel test robot <lkp@...el.com>
To: Sylvain Petinot <sylvain.petinot@...s.st.com>,
	benjamin.mugnier@...s.st.com, mchehab@...nel.org, robh@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] media: i2c: Add driver for ST VD56G3 camera sensor

Hi Sylvain,

kernel test robot noticed the following build warnings:

[auto build test WARNING on media-tree/master]
[also build test WARNING on linus/master v6.9-rc4 next-20240417]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sylvain-Petinot/media-dt-bindings-Add-ST-VD56G3-camera-sensor-binding/20240417-213838
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20240417133453.17406-3-sylvain.petinot%40foss.st.com
patch subject: [PATCH 2/2] media: i2c: Add driver for ST VD56G3 camera sensor
config: m68k-randconfig-r071-20240418 (https://download.01.org/0day-ci/archive/20240418/202404181322.l6Ajlqbf-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240418/202404181322.l6Ajlqbf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404181322.l6Ajlqbf-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/i2c/st-vd56g3.c:1164:12: warning: 'vd56g3_runtime_suspend' defined but not used [-Wunused-function]
    1164 | static int vd56g3_runtime_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/i2c/st-vd56g3.c:1142:12: warning: 'vd56g3_runtime_resume' defined but not used [-Wunused-function]
    1142 | static int vd56g3_runtime_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~


vim +/vd56g3_runtime_suspend +1164 drivers/media/i2c/st-vd56g3.c

  1141	
> 1142	static int vd56g3_runtime_resume(struct device *dev)
  1143	{
  1144		struct v4l2_subdev *sd = dev_get_drvdata(dev);
  1145		struct vd56g3 *sensor = to_vd56g3(sd);
  1146		struct i2c_client *client = sensor->i2c_client;
  1147		int ret;
  1148	
  1149		ret = vd56g3_power_on(sensor);
  1150		if (ret) {
  1151			dev_err(&client->dev, "Failed to power on %d", ret);
  1152			return ret;
  1153		}
  1154	
  1155		ret = vd56g3_boot(sensor);
  1156		if (ret) {
  1157			dev_err(&client->dev, "sensor boot failed %d", ret);
  1158			return ret;
  1159		}
  1160	
  1161		return ret;
  1162	}
  1163	
> 1164	static int vd56g3_runtime_suspend(struct device *dev)
  1165	{
  1166		struct v4l2_subdev *sd = dev_get_drvdata(dev);
  1167		struct vd56g3 *sensor = to_vd56g3(sd);
  1168	
  1169		return vd56g3_power_off(sensor);
  1170	}
  1171	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki