linux-kernel - Re: [RFC PATCH] sched/eevdf: Return leftmost entity in pick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZiC1LuqGAXGHgeDo@chenyu5-mobl2>
Date: Thu, 18 Apr 2024 13:52:46 +0800
From: Chen Yu <yu.c.chen@...el.com>
To: Tianchen Ding <dtcccc@...ux.alibaba.com>
CC: Xuewen Yan <xuewen.yan94@...il.com>, Peter Zijlstra
	<peterz@...radead.org>, Abel Wu <wuyun.abel@...edance.com>, Ingo Molnar
	<mingo@...hat.com>, Vincent Guittot <vincent.guittot@...aro.org>, Juri Lelli
	<juri.lelli@...hat.com>, Tim Chen <tim.c.chen@...el.com>, Tiwei Bie
	<tiwei.btw@...group.com>, Honglei Wang <wanghonglei@...ichuxing.com>, "Aaron
 Lu" <aaron.lu@...el.com>, Chen Yu <yu.chen.surf@...il.com>, Yujie Liu
	<yujie.liu@...el.com>, <linux-kernel@...r.kernel.org>, kernel test robot
	<oliver.sang@...el.com>
Subject: Re: [RFC PATCH] sched/eevdf: Return leftmost entity in pick_eevdf()
 if no eligible entity is found

On 2024-04-18 at 11:37:31 +0800, Tianchen Ding wrote:
> Hi, we've found a bug about reweight_eevdf(). Would you also please try this
> patchset?
> 
> https://lore.kernel.org/all/20240306022133.81008-1-dtcccc@linux.alibaba.com/
>

Sure, I'll have a try after I test Xuewen's patch. I assume your fix is mainly in
2/2 which adjusts the se->vruntime in reweight_eevdf() by using the correct
avg_vruntime(), although it might not be directly related to the s64 overflow issue
here, it is worthy a fix.

thanks,
Chenyu