linux-kernel - Re: [PATCH] powerpc: drop port I/O helpers for CONFIG_HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <59473eb6-1707-4bbf-85a3-ba4835f3ee7f@app.fastmail.com>
Date: Thu, 18 Apr 2024 08:59:52 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Michael Ellerman" <mpe@...erman.id.au>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Naresh Kamboju" <naresh.kamboju@...aro.org>,
 linux-kernel@...r.kernel.org, linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
 "Aneesh Kumar K . V" <aneesh.kumar@...nel.org>,
 "Anders Roxell" <anders.roxell@...aro.org>,
 "Kees Cook" <keescook@...omium.org>,
 "Niklas Schnelle" <schnelle@...ux.ibm.com>,
 clang-built-linux <llvm@...ts.linux.dev>,
 "Nick Desaulniers" <ndesaulniers@...gle.com>,
 "Nathan Chancellor" <nathan@...nel.org>, "Jeff Xu" <jeffxu@...omium.org>,
 "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
 "Dan Carpenter" <dan.carpenter@...aro.org>,
 "Nicholas Piggin" <npiggin@...il.com>,
 "Christophe Leroy" <christophe.leroy@...roup.eu>,
 "Bill Wendling" <morbo@...gle.com>, "Justin Stitt" <justinstitt@...gle.com>,
 "Baoquan He" <bhe@...hat.com>, "Mike Rapoport" <rppt@...nel.org>
Subject: Re: [PATCH] powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n

On Thu, Apr 18, 2024, at 08:26, Michael Ellerman wrote:
> Arnd Bergmann <arnd@...nel.org> writes:

> @@ -692,6 +692,7 @@ static inline void name at                          
>         \
>  #define writesw writesw
>  #define writesl writesl
>
> +#ifdef CONFIG_HAS_IOPORT
>  #define inb inb
>  #define inw inw
>  #define inl inl
> @@ -704,6 +705,8 @@ static inline void name at                          
>         \
>  #define outsb outsb
>  #define outsw outsw
>  #define outsl outsl
> +#endif // CONFIG_HAS_IOPORT
> +
>  #ifdef __powerpc64__
>  #define readq  readq
>  #define writeq writeq

I had included this at first, but then I still ran into
the same warnings because it ends up pulling in the
generic outsb() etc from include/asm-generic/io.h
that relies on setting a non-NULL PCI_IOBASE.

      Arnd