linux-kernel - Re: [PATCH] platform/x86: samsung-laptop: Use sysfs_emit() to replace the old interface sprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f8fac08-5368-443c-853e-6587b635e39b@redhat.com>
Date: Thu, 18 Apr 2024 10:46:23 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: yunshui <jiangyunshui@...inos.cn>, linux-kernel@...r.kernel.org,
 platform-driver-x86@...r.kernel.org
Cc: corentin.chary@...il.com, ilpo.jarvinen@...ux.intel.com,
 Ai Chao <aichao@...inos.cn>
Subject: Re: [PATCH] platform/x86: samsung-laptop: Use sysfs_emit() to replace
 the old interface sprintf()

Hi,

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>


On 4/18/24 9:05 AM, yunshui wrote:
>     As Documentation/filesystems/sysfs.rst suggested,
>     show() should only use sysfs_emit() or sysfs_emit_at() when formatting
>     the value to be returned to user space.
> 
> Signed-off-by: yunshui <jiangyunshui@...inos.cn>
> Signed-off-by: Ai Chao <aichao@...inos.cn>

But this double Signed-off-by is weird, looking at the From:
you (yunshui) are the author so your Signed-off-by is expected.

But Ai Chao's Signed-off-by here is weird, I would only
expect that if Ai Chao would be submitting the patch on
your behalf (for whatever reason).  Signed-off-by indicates
that you're either the author or the patch passed through
your hands. So I'll add my S-o-b for example when applying
this to my review-hans branch.

I guess you may want:

Reviewed-by: Ai Chao <aichao@...inos.cn>

here and in the other similar sysfs_emit() patches ?

Regards,

Hans




> ---
>  drivers/platform/x86/samsung-laptop.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
> index b4aa8ba35d2d..3d2f8e758369 100644
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -661,9 +661,9 @@ static ssize_t get_performance_level(struct device *dev,
>  	/* The logic is backwards, yeah, lots of fun... */
>  	for (i = 0; config->performance_levels[i].name; ++i) {
>  		if (sretval.data[0] == config->performance_levels[i].value)
> -			return sprintf(buf, "%s\n", config->performance_levels[i].name);
> +			return sysfs_emit(buf, "%s\n", config->performance_levels[i].name);
>  	}
> -	return sprintf(buf, "%s\n", "unknown");
> +	return sysfs_emit(buf, "%s\n", "unknown");
>  }
>  
>  static ssize_t set_performance_level(struct device *dev,
> @@ -744,7 +744,7 @@ static ssize_t get_battery_life_extender(struct device *dev,
>  	if (ret < 0)
>  		return ret;
>  
> -	return sprintf(buf, "%d\n", ret);
> +	return sysfs_emit(buf, "%d\n", ret);
>  }
>  
>  static ssize_t set_battery_life_extender(struct device *dev,
> @@ -813,7 +813,7 @@ static ssize_t get_usb_charge(struct device *dev,
>  	if (ret < 0)
>  		return ret;
>  
> -	return sprintf(buf, "%d\n", ret);
> +	return sysfs_emit(buf, "%d\n", ret);
>  }
>  
>  static ssize_t set_usb_charge(struct device *dev,
> @@ -878,7 +878,7 @@ static ssize_t get_lid_handling(struct device *dev,
>  	if (ret < 0)
>  		return ret;
>  
> -	return sprintf(buf, "%d\n", ret);
> +	return sysfs_emit(buf, "%d\n", ret);
>  }
>  
>  static ssize_t set_lid_handling(struct device *dev,