linux-kernel - Re: [PATCH v5 1/5] arch_topology: init capacity_freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 18 Apr 2024 11:50:08 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Beata Michalska <beata.michalska@....com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	ionela.voinescu@....com, vanshikonda@...amperecomputing.com,
	will@...nel.org, catalin.marinas@....com,
	vincent.guittot@...aro.org, sumitg@...dia.com,
	yang@...amperecomputing.com, lihuisong@...wei.com,
	viresh.kumar@...aro.org
Subject: Re: [PATCH v5 1/5] arch_topology: init capacity_freq_ref to 0

On Wed, Apr 17, 2024 at 10:38:44AM +0100, Beata Michalska wrote:
> From: Ionela Voinescu <ionela.voinescu@....com>
> 
> It's useful to have capacity_freq_ref initialized to 0 for users of
> arch_scale_freq_ref() to detect when capacity_freq_ref was not
> yet set.
> 
> The only scenario affected by this change in the init value is when a
> cpufreq driver is never loaded. As a result, the only setter of a
> cpu scale factor remains the call of topology_normalize_cpu_scale()
> from parse_dt_topology(). There we cannot use the value 0 of
> capacity_freq_ref so we have to compensate for its uninitialized state.
>

Reviewed-by: Sudeep Holla <sudeep.holla@....com>

-- 
Regards,
Sudeep