linux-kernel - Re: [PATCH v9 3/4] mm/memory: add any_dirty optional pointer to folio_pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c73423cb-3288-47aa-b389-22566e883db7@redhat.com>
Date: Thu, 18 Apr 2024 13:59:58 +0200
From: David Hildenbrand <david@...hat.com>
To: Lance Yang <ioworker0@...il.com>, akpm@...ux-foundation.org
Cc: ryan.roberts@....com, 21cnbao@...il.com, mhocko@...e.com,
 fengwei.yin@...el.com, zokeefe@...gle.com, shy828301@...il.com,
 xiehuan09@...il.com, wangkefeng.wang@...wei.com, songmuchun@...edance.com,
 peterx@...hat.com, minchan@...nel.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 3/4] mm/memory: add any_dirty optional pointer to
 folio_pte_batch()

On 18.04.24 12:57, Lance Yang wrote:
> This commit adds the any_dirty pointer as an optional parameter to
> folio_pte_batch() function. By using both the any_young and any_dirty pointers,
> madvise_free can make smarter decisions about whether to clear the PTEs when
> marking large folios as lazyfree.
> 
> Suggested-by: David Hildenbrand <david@...hat.com>
> Signed-off-by: Lance Yang <ioworker0@...il.com>
> ---
>   mm/internal.h | 12 ++++++++++--
>   mm/madvise.c  | 19 ++++++++++++++-----
>   mm/memory.c   |  4 ++--
>   3 files changed, 26 insertions(+), 9 deletions(-)
> 
> diff --git a/mm/internal.h b/mm/internal.h
> index c6483f73ec13..daa59cef85d7 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -134,6 +134,8 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags)
>    *		  first one is writable.
>    * @any_young: Optional pointer to indicate whether any entry except the
>    *		  first one is young.
> + * @any_dirty: Optional pointer to indicate whether any entry except the
> + *		  first one is dirty.
>    *

I was also wondering if we should make that function return a 
pte+nr_pages, instead of only nr_pages, and then simply have the 
function, based on new flags, merge data into the original PTE.

But let's do that separately.

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb