linux-kernel - Re: [PATCH] blk-iocost: do not WARNING if iocg has already offlined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9a65bb0-70ce-f79f-916d-0dddfd88f9e9@huaweicloud.com>
Date: Thu, 18 Apr 2024 20:21:53 +0800
From: Li Nan <linan666@...weicloud.com>
To: Yu Kuai <yukuai1@...weicloud.com>, linan666@...weicloud.com,
 tj@...nel.org, josef@...icpanda.com, axboe@...nel.dk
Cc: hch@....de, cgroups@...r.kernel.org, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, yi.zhang@...wei.com, houtao1@...wei.com,
 yangerkun@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH] blk-iocost: do not WARNING if iocg has already offlined



在 2024/4/18 16:52, Yu Kuai 写道:
> 
> 
> 在 2024/04/18 15:23, linan666@...weicloud.com 写道:
>> From: Li Nan <linan122@...wei.com>
>>
>> In iocg_pay_debt(), warn is triggered if 'active_list' is empty, which
>> is intended to confirm iocg is avitve when it has debt. However, warn
>> can be triggered during removing cgroup controller, as
>> iocg_waitq_timer_fn() is awakened at that time.
>>
>>    WARNING: CPU: 0 PID: 2344971 at block/blk-iocost.c:1402 
>> iocg_pay_debt+0x14c/0x190
> 
> This line doesn't match the code from mainline, please mention that
> which kernel release you're testing.
> 

Thanks for your review.
I tested at 5.10, but mainline has the same issue.

> Other than that, ioc_pd_free() indeed clear 'active_list' before
> canceling the timer, this patch looks good to me.
> 
> Reviewed-by: Yu Kuai <yukuai3@...wei.com>

-- 
Thanks,
Nan