[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<AS4PR04MB93862A14E6FAD42A2B5F6301E10E2@AS4PR04MB9386.eurprd04.prod.outlook.com>
Date: Thu, 18 Apr 2024 01:38:16 +0000
From: Joy Zou <joy.zou@....com>
To: Frank Li <frank.li@....com>
CC: Peng Fan <peng.fan@....com>, "vkoul@...nel.org" <vkoul@...nel.org>,
"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "dmaengine@...r.kernel.org"
<dmaengine@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>
Subject: RE: [PATCH v4 1/2] dmaengine: fsl-edma: clean up unused
"fsl,imx8qm-adma" compatible string
> -----Original Message-----
> From: Frank Li <frank.li@....com>
> Sent: 2024年4月17日 22:40
> To: Joy Zou <joy.zou@....com>
> Cc: Peng Fan <peng.fan@....com>; vkoul@...nel.org; robh@...nel.org;
> krzk+dt@...nel.org; conor+dt@...nel.org; imx@...ts.linux.dev;
> dmaengine@...r.kernel.org; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org
> Subject: Re: [PATCH v4 1/2] dmaengine: fsl-edma: clean up unused
> "fsl,imx8qm-adma" compatible string
> > diff --git a/drivers/dma/fsl-edma-common.c
> > b/drivers/dma/fsl-edma-common.c index f9144b015439..ed93e01282d5
> > 100644
> > --- a/drivers/dma/fsl-edma-common.c
> > +++ b/drivers/dma/fsl-edma-common.c
> > @@ -75,18 +75,10 @@ static void fsl_edma3_enable_request(struct
> > fsl_edma_chan *fsl_chan)
> >
> > flags = fsl_edma_drvflags(fsl_chan);
> > val = edma_readl_chreg(fsl_chan, ch_sbr);
> > - /* Remote/local swapped wrongly on iMX8 QM Audio edma */
> > - if (flags & FSL_EDMA_DRV_QUIRK_SWAPPED) {
>
> You forget remove FSL_EDMA_DRV_QUIRK_SWAPPED in fsl-edma-common.h
Thanks your comments!
Yeah, will remove it in next version.
BR
Joy Zou
>
> Frank
>
Powered by blists - more mailing lists