linux-kernel - Re: [PATCH v2 resend] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZiEoiuHbIyyWs5hE@smile.fi.intel.com>
Date: Thu, 18 Apr 2024 17:04:58 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Zeng Heng <zengheng4@...wei.com>
Cc: linus.walleij@...aro.org, dan.carpenter@...aro.org,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	liwei391@...wei.com
Subject: Re: [PATCH v2 resend] pinctrl: devicetree: fix refcount leak in
 pinctrl_dt_to_map()

On Thu, Apr 18, 2024 at 07:58:13PM +0800, Zeng Heng wrote:
> If we fail to allocate propname buffer, we need to drop the reference
> count we just took, otherwise it will lead reference leak. Here the
> error exit path is modified to jump to the err label and call
> pinctrl_dt_free_maps() which would drop the counter.
> 
> In the meantime, if it is found that the property 'pinctrl-0' is not
> present, ENODEV is returned and also jump to the err label and call the
> free function, in case the Smatch tool complains.

..

> ---
> v2: add a comment and modify the commit message, without any logical
>     changes.

You probably didn't get what I was saying...
Linus already applied your version, what is missing is the comment.
This should be done as a followup patch.

-- 
With Best Regards,
Andy Shevchenko