linux-kernel - Re: [PATCH] x86/cpufeatures: Fix dependencies for GFNI, VAES, and VPCLMULQDQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d28f1dc-0aea-4b91-9df7-1a6d3a291e2e@intel.com>
Date: Thu, 18 Apr 2024 07:24:10 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Eric Biggers <ebiggers@...nel.org>, x86@...nel.org
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/cpufeatures: Fix dependencies for GFNI, VAES, and
 VPCLMULQDQ

On 4/16/24 23:04, Eric Biggers wrote:
> Fix cpuid_deps[] to list the correct dependencies for GFNI, VAES, and
> VPCLMULQDQ.  These features don't depend on AVX512, and there exist CPUs
> that support these features but not AVX512.  GFNI actually doesn't even
> depend on AVX.
> 
> This prevents GFNI from being unnecessarily disabled if AVX is disabled
> to mitigate the GDS vulnerability.

Looks like the original commit was quite confused.  Thanks for finding this.

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>