linux-kernel - Re: [PATCH 1/1] Documentation/core-api: Add swiotlb documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZiEuGIoa-FCE0p4X@casper.infradead.org>
Date: Thu, 18 Apr 2024 15:28:40 +0100
From: Matthew Wilcox <willy@...radead.org>
To: mhklinux@...look.com
Cc: robin.murphy@....com, joro@...tes.org, will@...nel.org, hch@....de,
	m.szyprowski@...sung.com, corbet@....net, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	petr@...arici.cz, roberto.sassu@...weicloud.com
Subject: Re: [PATCH 1/1] Documentation/core-api: Add swiotlb documentation

On Thu, Apr 18, 2024 at 06:52:13AM -0700, mhkelley58@...il.com wrote:
> There's currently no documentation for the swiotlb. Add documentation
> describing usage scenarios, the key APIs, and implementation details.
> Group the new documentation with other DMA-related documentation.

This is really well written.  Thank you.  One minor nit below.

> +Usage Scenarios
> +---------------
> +The swiotlb was originally created to handle DMA for devices
> +with addressing limitations. As physical memory sizes grew
> +beyond 4 Gbytes, some devices could only provide 32-bit DMA
> +addresses. By allocating bounce buffer memory below the 4 Gbyte

I'd prefer GiB to Gbytes; we might also prefer GB, Gigabyte or Gibibyte,
but Gbytes seems wrong.

You've written a lot here, and I'm not an expert on swiommu, but nothing
else leapt out at me.